feat(fcm): Add support for bandwidth constrained and restricted satellite APIs#940
feat(fcm): Add support for bandwidth constrained and restricted satellite APIs#940jonathanedey wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new configuration options for Android messages, enabling developers to specify whether messages should be delivered when a device is operating under specific network restrictions, such as Data Saver mode or a satellite connection. This enhancement provides finer control over message delivery behavior, improving the reliability and user experience for applications in diverse network environments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for bandwidth_constrained_ok and restricted_satellite_ok to the AndroidConfig object. The changes are correctly implemented in the data model, encoder, and tests, following the existing patterns for similar boolean fields. My review includes one suggestion to refactor the new tests to reduce code duplication and improve maintainability.
2 participants
This change adds the
bandwidth_constrained_okandrestricted_satellite_okoptions to theAndroidConfigobject. This gives developers granular control over message delivery when an Android device is operating under restricted network conditions, such as Data Saver mode or an active satellite network connection.